JS console error cleanup

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

JS console error cleanup

jcalcote
Hi Yaguang,

Here are a few bug fixes for javascript console errors that show up in VSM:

I believe e7aedb582487.css is a generated file, based on the contents of the following files, so you can just ignore it if this is true:

diff -Naur vsm-dashboard.orig/static/dashboard/css/e7aedb582487.css vsm-dashboard/static/dashboard/css/e7aedb582487.css
--- vsm-dashboard.orig/static/dashboard/css/e7aedb582487.css    2016-01-13 18:26:17.499876035 -0700
+++ vsm-dashboard/static/dashboard/css/e7aedb582487.css 2016-01-18 11:48:26.191139713 -0700
@@ -1,6 +1,6 @@
 @charset "UTF-8";
 /*! normalize.css v3.0.1 | MIT License | git.io/normalize */
-@import url('/horizon/lib/bootstrap_datepicker/datepicker.css');
+/*@import url('/horizon/lib/bootstrap_datepicker/datepicker.css'); */
 html {
   font-family: sans-serif;
   -ms-text-size-adjust: 100%;

datepicker.css is not in the horizon library (as it probably once was). Since this is true and it seems to have no effect on VSM operation, I've just removed the reference from horizon.scss:

diff -Naur vsm-dashboard.orig/static/dashboard/scss/horizon.scss vsm-dashboard/static/dashboard/scss/horizon.scss
--- vsm-dashboard.orig/static/dashboard/scss/horizon.scss       2016-01-13 18:26:17.499876035 -0700
+++ vsm-dashboard/static/dashboard/scss/horizon.scss    2016-01-18 11:47:59.871282301 -0700
@@ -4,7 +4,7 @@
 $modal-md: 732px;

 @import "../../bootstrap/scss/bootstrap/";
-@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
+//@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
 @import "_variables";
 @import "_accordion_nav";


vsm.date.js is also missing from the js directory - again, since this seems to have no ill effect on the operation of the software, I've just removed the import of this .js file:

diff -Naur vsm-dashboard.orig/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html vsm-dashboard/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html
--- vsm-dashboard.orig/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html      2016-01-13 18:26:17.523875900 -0700
+++ vsm-dashboard/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html   2016-01-18 11:37:44.330617291 -0700
@@ -286,6 +286,5 @@
     {{ block.super }}
     <script src="{{ STATIC_URL }}lib/echarts.js"></script>
     <script src="{{ STATIC_URL }}dashboard/js/message.js"></script>
-    <script src="{{ STATIC_URL }}dashboard/js/vsm.date.js"></script>
     <script src="{{ STATIC_URL }}dashboard/js/dashboard.js"></script>
 {% endblock %}

Another copy of horizon.scss - not sure which is definitive:

diff -Naur vsm-dashboard.orig/vsm_dashboard/static/dashboard/scss/horizon.scss vsm-dashboard/vsm_dashboard/static/dashboard/scss/horizon.scss
--- vsm-dashboard.orig/vsm_dashboard/static/dashboard/scss/horizon.scss 2016-01-13 18:26:17.515875945 -0700
+++ vsm-dashboard/vsm_dashboard/static/dashboard/scss/horizon.scss      2016-01-18 11:48:54.210987916 -0700
@@ -4,7 +4,7 @@
 $modal-md: 732px;

 @import "/bootstrap/scss/bootstrap";
-@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
+//@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
 @import "_variables";
 @import "_accordion_nav";


Regards,
John
Reply | Threaded
Open this post in threaded view
|

RE: JS console error cleanup

ywang19
Administrator

Good catch. All accepted except e7aedb582487.css changes.

 

 

From: jcalcote [via vsm-discuss] [mailto:ml-node+[hidden email]]
Sent: Tuesday, January 19, 2016 2:12 AM
To: Wang, Yaguang
Subject: JS console error cleanup

 

Hi Yaguang,

Here are a few bug fixes for javascript console errors that show up in VSM:

I believe e7aedb582487.css is a generated file, based on the contents of the following files, so you can just ignore it if this is true:

 
diff -Naur vsm-dashboard.orig/static/dashboard/css/e7aedb582487.css vsm-dashboard/static/dashboard/css/e7aedb582487.css
--- vsm-dashboard.orig/static/dashboard/css/e7aedb582487.css    2016-01-13 18:26:17.499876035 -0700
+++ vsm-dashboard/static/dashboard/css/e7aedb582487.css 2016-01-18 11:48:26.191139713 -0700
@@ -1,6 +1,6 @@
 @charset "UTF-8";
 /*! normalize.css v3.0.1 | MIT License | git.io/normalize */
-@import url('/horizon/lib/bootstrap_datepicker/datepicker.css');
+/*@import url('/horizon/lib/bootstrap_datepicker/datepicker.css'); */
 html {
   font-family: sans-serif;
   -ms-text-size-adjust: 100%;


datepicker.css is not in the horizon library (as it probably once was). Since this is true and it seems to have no effect on VSM operation, I've just removed the reference from horizon.scss:

 
diff -Naur vsm-dashboard.orig/static/dashboard/scss/horizon.scss vsm-dashboard/static/dashboard/scss/horizon.scss
--- vsm-dashboard.orig/static/dashboard/scss/horizon.scss       2016-01-13 18:26:17.499876035 -0700
+++ vsm-dashboard/static/dashboard/scss/horizon.scss    2016-01-18 11:47:59.871282301 -0700
@@ -4,7 +4,7 @@
 $modal-md: 732px;
 
 @import "../../bootstrap/scss/bootstrap/";
-@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
+//@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
 @import "_variables";
 @import "_accordion_nav";
 


vsm.date.js is also missing from the js directory - again, since this seems to have no ill effect on the operation of the software, I've just removed the import of this .js file:

 
diff -Naur vsm-dashboard.orig/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html vsm-dashboard/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html
--- vsm-dashboard.orig/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html      2016-01-13 18:26:17.523875900 -0700
+++ vsm-dashboard/vsm_dashboard/dashboards/vsm/overview/templates/overview/index.html   2016-01-18 11:37:44.330617291 -0700
@@ -286,6 +286,5 @@
     {{ block.super }}
     <script src="{{ STATIC_URL }}lib/echarts.js"></script>
     <script src="{{ STATIC_URL }}dashboard/js/message.js"></script>
-    <script src="{{ STATIC_URL }}dashboard/js/vsm.date.js"></script>
     <script src="{{ STATIC_URL }}dashboard/js/dashboard.js"></script>
 {% endblock %}


Another copy of horizon.scss - not sure which is definitive:

 
diff -Naur vsm-dashboard.orig/vsm_dashboard/static/dashboard/scss/horizon.scss vsm-dashboard/vsm_dashboard/static/dashboard/scss/horizon.scss
--- vsm-dashboard.orig/vsm_dashboard/static/dashboard/scss/horizon.scss 2016-01-13 18:26:17.515875945 -0700
+++ vsm-dashboard/vsm_dashboard/static/dashboard/scss/horizon.scss      2016-01-18 11:48:54.210987916 -0700
@@ -4,7 +4,7 @@
 $modal-md: 732px;
 
 @import "/bootstrap/scss/bootstrap";
-@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
+//@import "/horizon/lib/bootstrap_datepicker/datepicker.css";
 @import "_variables";
 @import "_accordion_nav";
 


Regards,
John


If you reply to this email, your message will be added to the discussion below:

http://vsm-discuss.33411.n7.nabble.com/JS-console-error-cleanup-tp387.html

To start a new topic under vsm-discuss, email [hidden email]
To unsubscribe from vsm-discuss, click here.
NAML